Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update segmented control visual design #3289

Merged
merged 38 commits into from
Feb 24, 2025
Merged

chore: Update segmented control visual design #3289

merged 38 commits into from
Feb 24, 2025
+170 −117

Conversation

at-susie
Copy link
Member

Description

Improve the visual design for segmented control to mitigate the bulkiness.

image

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (22d7bca) to head (4f87e32).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3289    +/-   ##
========================================
  Coverage   96.42%   96.42%            
========================================
  Files         791      791            
  Lines       22603    22605     +2     
  Branches     7814     7396   -418     
========================================
+ Hits        21795    21797     +2     
- Misses        754      801    +47     
+ Partials       54        7    -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-susie at-susie marked this pull request as ready for review February 12, 2025 17:25
@at-susie at-susie requested a review from a team as a code owner February 12, 2025 17:25
@at-susie at-susie requested review from gethinwebster and removed request for a team February 12, 2025 17:25
gethinwebster
gethinwebster requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@gethinwebster gethinwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok, but the CSS needs to be made a bit more token-/variable-based

gethinwebster
gethinwebster previously approved these changes Feb 17, 2025
View reviewed changes
@at-susie at-susie added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2025
@at-susie at-susie added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 20d2f3a Feb 24, 2025
38 checks passed
@at-susie at-susie deleted the update-segment-control branch February 24, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gethinwebster gethinwebster gethinwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@at-susie @gethinwebster @georgylobko